docs(auth): update Screen Transitions samples to the Navigation 3 AuthUITransitions - #2475
docs(auth): update Screen Transitions samples to the Navigation 3 AuthUITransitions#2475demolaf wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the auth/README.md documentation to reflect changes in screen transitions, moving from individual enter/exit transitions to unified transition specs using togetherWith. It also adds documentation for per-destination animations and updates notes on default transitions. Feedback is provided regarding an inconsistency in the vertical slide transition example, where the exit animation direction contradicts the accompanying comment.
48aee3c to
65e890b
Compare
65e890b to
97bbc01
Compare
5d227bf to
2d959d6
Compare
97bbc01 to
a86f693
Compare
|
Superseded by #2496, which absorbs both commits from this branch with authorship intact and adds the Closing here so the two stop conflicting: #2496 rewrites §AuthFlowController and §Low-Level API in the same file, and both PRs edited §Screen Transitions from the same base. Nothing from this branch is lost - the five samples, the per-destination |
github-project-automation
Bot
moved this from Backlog
to Done
in studio-2394994192-60a69
1 participant
The Screen Transitions samples still use the Navigation 2 constructor —
enterTransition/exitTransition/popEnterTransition/popExitTransition— which no longer exists, so none of the four compile.AuthUITransitionsnow takes oneContentTransformper direction:transitionSpec,popTransitionSpecandpredictivePopTransitionSpec.Rewrites the four samples against the new constructor, pairing each enter/exit with
togetherWith, and adds a per-destination sample using the publicScene<NavKey>.authRoute(). The closing note now says each spec falls back to the default 700ms cross-fade independently —predictivePopTransitionSpecdoes not fall back topopTransitionSpec, and it fires when the gesture starts rather than when a back completes.Compiled all five samples verbatim against the module to check they build.
Maintainer note: Fixes internal CPRN-404